Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of message for deprecated attributes #402

Conversation

sadielbartholomew
Copy link
Member

@sadielbartholomew sadielbartholomew commented May 9, 2022

Quick one to fix a formatting issue (spotted in #395 (review)) due to a (valid) change that went in as part of #384 but which has been partially reverted, likely due to a merge conflict resolution mistake somewhere along the line.

Before this PR for e.g. d.ismasked() on some cf.Data:

DeprecationError: Data attribute 'ismasked' has been deprecated at version TODODASK and will be removed at version  and will be removed at version 5.0.0. Use the 'is_masked' attribute instead

And after this PR, the obvious fix is made:

DeprecationError: Data attribute 'ismasked' has been deprecated at version TODODASK and will be removed at version 5.0.0. Use the 'is_masked' attribute instead

No review requested as this is a trivial fix.

@sadielbartholomew sadielbartholomew added code tidy dask Relating to the use of Dask labels May 9, 2022
@sadielbartholomew sadielbartholomew self-assigned this May 9, 2022
@sadielbartholomew
Copy link
Member Author

The CI jobs are currently failing due to not having the required cfdm version, which I am fixing separately, so I have cancelled the jobs. test_Data.py passes locally, so all good to merge.

@sadielbartholomew sadielbartholomew merged commit b9affa9 into NCAS-CMS:lama-to-dask May 9, 2022
@sadielbartholomew sadielbartholomew deleted the deprecated-attr-formatting branch May 9, 2022 15:45
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code tidy dask Relating to the use of Dask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants